search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Redo pr 211 #224

Closed willkg closed 10 years ago

willkg commented 10 years ago

Re-applies pull #211 and adds a commit that tweaks some of the code style.

r?

willkg commented 10 years ago

@robhudson Can you take a look at this before Thursday? It's pretty straight-forward and cleans up some irritating things about how facets worked in the past.

robhudson commented 10 years ago

r+wc.

willkg commented 10 years ago

^^^

I screwed up and amended the changes to the previous commit. That fixes the unordered facet types list, tweaks the FacetResult code and changes a bunch of " to '.

@robhudson Does that look ok?

robhudson commented 10 years ago

Looks good to me.

willkg commented 10 years ago

Sweet--landed in master:

Thank you!