Python 3.3+? - Githubissues

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python

http://elasticutils.rtfd.org

BSD 3-Clause "New" or "Revised" License

243 stars 76 forks source link

Python 3.3+? #230

Closed eire1130 closed 10 years ago

eire1130 commented 10 years ago

I wrote a patch for this that passes tests and seems to work.

If this is something you'd like to target for .10, I can send a PR this weekend or something.

It's not as much work as you might think, mainly just adding six and moving off some deprecated features from 2k, like .has_key and stuff.

Would any specific tests be needed beyond what is already there?

Thoughts?

willkg commented 10 years ago

Yes, please send a PR! You rock!

I'm not sure what tests would be needed other than what's there. I think for 0.10 we could say "preliminary support for Python 3.3+" and then see if anyone brings up bugs. Then we can add tests for those as we go along.

willkg commented 10 years ago

This landed. Closing this out.