search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Python3 #231

Closed eire1130 closed 10 years ago

eire1130 commented 10 years ago

And here's the PR for issue #230

Sadly Travis doesn't have python3.4 yet, but I did run the tests locally on 3.4 and they all pass. So until that fateful day when they add it, we will need to make due with python3.3 in Travis.

As you can see, there is less compliance then one might have thought. The biggest thing was that dictionaries return generators now for .keys, values, and .items.

I didn't touch Tox or docs.

rouge8 commented 10 years ago

:+1: I added Tox targets in 4d024929c3ba87ea178b3b13122f2ece9c9ecba7 if you want to cherry-pick that into this pull request.

eire1130 commented 10 years ago

I just added this thank you

willkg commented 10 years ago

Sorry it took so long to look at this. Thank you!