search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

terms_stats facet type support #254

Open eire1130 opened 9 years ago

eire1130 commented 9 years ago

adds terms stats support.

I think it's failing because travis pulling down the wrong version of ES and my code is still based on .9. I can update it if need be. Tests are passing locally for me though.

Much <3 if this can be into .10.

willkg commented 9 years ago

0.10 was released already, so this won't make it into that version. But possibly 0.11 or 0.10.1 depending on how the future goes.

This looks ok other than a bunch of pep8-related problems which makes it hard to read in github diff. Can you run pep8 or flake8 on this and fix the resulting issues? Then I'll go through it more closely.

willkg commented 9 years ago

I'm definitely going to do an ElasticUtils 0.10.1 release. I'm happy to wait for this PR to resolve itself so it can get in.

Can you work through the comments in the next couple of days? If not, I can take your PR and fix it up.

willkg commented 9 years ago

Also, thank you for doing this!

eire1130 commented 9 years ago

Thanks for looking at this, I'll try to look at this in the next day or so.

willkg commented 9 years ago

Awesome--thank you!