search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Fix: S not using get_es from mapping type #269

Closed regadas closed 9 years ago

regadas commented 9 years ago

I know that this PR as failed tests most of them due to:

type object '<SomeMappingType>' has no attribute 'get_es'

My point with this is to bring to discussing whether we should require or not the override of Indexable.get_es method when doing something like:

S(SomeMappingType).query(...)

Also, should chained .es() calls override the mapping type get_es?

willkg commented 9 years ago

Sounds like you should open up an issue for this instead of a pull request so we can document whatever it is you're trying to do and discuss solutions.

Given that, I'm going to close this out.