search

mozilla / email-tabs

An experimental add-on to email a list of all your tabs
https://addons.mozilla.org/en-US/firefox/addon/email-tabs/
Mozilla Public License 2.0
39 stars 17 forks source link

Fixing eslint warnings/errors #229

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

Circle CI is currently failing w/ the following:

> email-tabs@0.1.0 lint:js /home/circleci/project
> eslint addon --ext=js,jsx

Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.

/home/circleci/project/addon/popup.jsx
  296:10  error  Unknown property 'class' found, use 'className' instead  react/no-unknown-property

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

This makes it not do that. And "fixes" at least part of our web-ext lint woes w/ an unrelated --self-hosted tweak. #yolo