search

mozilla / ember-cli-fxos

Ember-cli add-on for creating Firefox OS applications
11 stars 2 forks source link

Validation #11

Closed brittanydionigi closed 9 years ago

brittanydionigi commented 9 years ago

This adds an ember fxos:validate command that uses the firefox-app-validator-manifest module to validate the processed manifest.webapp file in the /dist directory. (Readme includes a note that the validator is still a WIP and may not catch all errors)

tofumatt commented 9 years ago

Looks good to me, not sure why Travis can't run the tests, but I'll try to re run them.

tofumatt commented 9 years ago

Oh, looks like this might fail if the public directory doesn't already exist. That's what travis seems to be complaining about. Maybe create the public directory if it doesn't already exist?

brittanydionigi commented 9 years ago

@tofumatt actually our builds have been failing on that since day one O_O Ha. It's looking for a /public dir at the root of the addon (which will never exist. and shouldn't. so we don't want to create it.) When that code is run within the context of an app, it maps to the correct /public dir (the one at the root of the app). Not sure why travis would be handling it differently. Will investigate.

brittanydionigi commented 9 years ago

Actually I guess I see some addons stubbed with empty folders of .gitkeep files. I'd like to go that route for now until I have some time to look through issues on the ember-cli project. Stubbing the public dir won't do any harm.

tofumatt commented 9 years ago

Ohhhhh whoops. But yeah, let's try to fix it, maybe even separately if this works outside of travis. No need to stall this PR if the travis failure isn't directly related to it.

-tofumatt On 2 Mar 2015 23:58, ".DS_Storoz" notifications@github.com wrote:

@tofumatt https://github.com/tofumatt actually our builds have been failing on that since day one O_O Ha. It's looking for a /public dir at the root of the addon (which will never exist. and shouldn't. so we don't want to create it.) When that code is run within the context of an app, it maps to the correct /public dir (the one at the root of the app). Not sure why travis would be handling it differently. Will investigate.

— Reply to this email directly or view it on GitHub https://github.com/mozilla/ember-cli-fxos/pull/11#issuecomment-76857108.