search

mozilla / ensemble

The platform that powers the Firefox Public Data Report :violin: :trumpet: :musical_keyboard:
https://data.firefox.com/
Mozilla Public License 2.0
20 stars 14 forks source link

Bump package.json version to 1.0.0 #184

Closed openjck closed 5 years ago

openjck commented 5 years ago

When we launch Ensemble, we should bump package.json version to 1.0.0.

pdehaan commented 5 years ago

Silly question, but is “ensemble” going to be the final name, or we planning a repo rename before we make this public and launch?

openjck commented 5 years ago

Silly question, but is “ensemble” going to be the final name, or we planning a repo rename before we make this public and launch?

I assumed we would keep it the same. It's the name for the platform whereas Firefox Public Data Report is the name of the site. Like kuma/MDN, bedrock/mozilla.org, etc. But I'm fine with changing it if we want to.

openjck commented 5 years ago

Accidentally closed. Reopening...

openjck commented 5 years ago

I decided to remove the version number since we no longer need to adhere to Dockerflow.

pdehaan commented 5 years ago

Curious, why don't we need to adhere to Dockerflow? Without the /__version__ endpoint, how will I/we know what SHA is deployed to dev/stage/prod?

openjck commented 5 years ago

DataOps decided to host ensemble as a static site using S3 and Cloudfront. Along with that went the two solutions we had previously used to respond to custom endpoints: create-react-app-buildpack (at first) and the Express back-end (later). But if __version__ is useful, and it sounds like it is, I'd be happy to add it back.