search

mozilla / eslint-plugin-no-unsanitized

Custom ESLint rule to disallows unsafe innerHTML, outerHTML, insertAdjacentHTML and alike
Mozilla Public License 2.0
223 stars 34 forks source link

debating typescript support and maintenance #133

Open mozfreddyb opened 4 years ago

mozfreddyb commented 4 years ago

Hi @LironEr, @LukeWoodG and @ffflorian (included due to our recent discussions in #126 and #111),

I understand that you're using this rule and need typescript support, but I feel hesitant to add support for something that we don't use ourselves and won't be able to provide prioritized maintenance as we would do for other issues and now I'm considering my options. Here's me trying to summarize my thought process so far:

I want to avoid a fork, to not scatter smart people resources or end up with inconsistently applied improvements on either. But I also want to help you figure out a path forward.

Here's what I could imagine: I'd be willing to take a couple of small, well-tested pull requests that support extra expressions. But I'd need one of you to sign-up as code-owner for typescript support and take responsibility for keeping it in shape. This includes triage for typescript-bugs and code-review for typescript related pull requests. This will not give you the full authority, I'd want to maintain supervision and final ruling with the existing Mozilla reviewers.

I see that github has a concept of code ownership that would help assign issues automatically, but it seems to use a file-based granularity, which I don't think would work here.

LukeWood commented 4 years ago

Hey there @mozfreddyb (switched github accounts),

I've been working on a PR and would benefit greatly from your review when it's ready.

I also think avoiding a fork would be great - that being said I'll need to confirm with our team that we are willing to take up ownership of typescript support. I'll keep you posted :)