search

mozilla / eslint-plugin-no-unsanitized

Custom ESLint rule to disallows unsafe innerHTML, outerHTML, insertAdjacentHTML and alike
Mozilla Public License 2.0
222 stars 33 forks source link

try github actions #158

Closed mozfreddyb closed 3 years ago

mozfreddyb commented 3 years ago

There are lots of contributors to this repo, but I'm not sure who would be experienced with reviewing a move to GitHub Actions. Would you be experienced in this - or know someone who might be, @hwine?

hwine commented 3 years ago

@mozfreddyb I can't speak to the equivalence of this setup to the prior CI (although it does appear that you're adding a lot more coverage with GitHub actions). You might find someone more experienced by asking in our matrix github-admin channel.

I can say that all the 3rd party actions used are already approved for use in the 'mozilla' org, so have fun!

mozfreddyb commented 3 years ago

I'll admit that I stole the config from https://github.com/prettier/eslint-plugin-prettier/blob/master/.github/workflows/ci.yml, but they seem to have similar aims and I believe it's a good idea to expand test coverage to various versions that we currently support. :)

mozfreddyb commented 3 years ago

Uhm, this project has clearly too restrictive check-in policies and not enough contributors. I'll consider changing either of these, but not in here. Maybe @Standard8 you can help out again? :)