search

mozilla / eslint-plugin-no-unsanitized

Custom ESLint rule to disallows unsafe innerHTML, outerHTML, insertAdjacentHTML and alike
Mozilla Public License 2.0
223 stars 34 forks source link

moar property checking? #33

Closed mozfreddyb closed 7 years ago

mozfreddyb commented 7 years ago

More checking for props over this being explicit

mozfreddyb commented 7 years ago

should be its own rule, I think

jonathanKingston commented 7 years ago

Fairly certain this can be now closed however would like an eye on if I have made it less explicit by my custom checks.

mozfreddyb commented 7 years ago

yep, I think we have nailed the cases down where we expect a specific expression. I was slightly concerned about future-proofing, but I think we got that solved.

The fact that our error reporting makes a suggestion to file an issue, will be a bit annoying though, given that might cause ESLint on Treeherder to fail for everyone if someone introduces a new pattern :/