search

mozilla / eslint-plugin-no-unsanitized

Custom ESLint rule to disallows unsafe innerHTML, outerHTML, insertAdjacentHTML and alike
Mozilla Public License 2.0
223 stars 34 forks source link

Update eslint to version 4.16.0 #76

Closed epixa closed 6 years ago

epixa commented 6 years ago

I'm not sure what requirements this project has for bumping eslint, but we noticed that the eslint dependency was lagging behind the eslint project itself when we were introducing no-unsanitized in kibana, so I figured I'd open a PR to get the process started.

Note, bumping eslint required a change to runHelper to make sure it could pass what I assume are new default linting behaviors in eslint 4. Let me know if you'd prefer a different solution than relying on the defaults.

mozfreddyb commented 6 years ago

That's perfect. Thank you!

spalger commented 6 years ago

@mozfreddyb would you be open to a pr moving eslint to a peerDependency?

spalger commented 6 years ago

Actually, looks like it's also a devDependency. Maybe it's less desirable to list it in dep deps and peer deps