mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
121 stars 186 forks source link

The "Technical Risks Description" input field can wrongly be saved with empty spaces #1082

Closed Softvision-RemusDranca closed 5 years ago

Softvision-RemusDranca commented 5 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to "https://experimenter.stage.mozaws.net/".
  2. Open the created experiment from prerequisites.
  3. Click the "Edit" button from "Risks" section.
  4. Insert an empty space in the input field.
  5. Click the "Save Draft and Finish" button and observe the behavior.

[Expected result]:

[Actual result]:

[Notes]:

peterbe commented 5 years ago

Curious. It's not required but it doesn't say "Optional" under the label.

The template is probably busted because it if-statements on experiment.risk_technical but then attempts to display experiment.risk_technical_description.

peterbe commented 5 years ago

Ignore my comment above. I didn't really understand it properly. I have a solution coming in.

Softvision-RemusDranca commented 5 years ago

I have verified this issue and is no longer reproducible on Experimenter stage "https://stage.experimenter.nonprod.dataops.mozgcp.net/" website after the v2.28.0 stage deployment. Tested on Windows 10x64, Mac 10.14 and Arch Linux 4.16.6 x64.