mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
114 stars 175 forks source link

There is no notification displayed if the Bugzilla ticket isn't created, when Bugzilla resets their database #1083

Closed Softvision-RemusDranca closed 5 years ago

Softvision-RemusDranca commented 5 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to "https://experimenter.stage.mozaws.net/".
  2. Open the experiment from prerequisites and click the "Ready for Sign-Off" button.
  3. Refresh the page and observe the notifications displayed under the experiment's title.

[Expected result]:

[Actual result]:

[Notes]:

jaredlockhart commented 5 years ago

Yes this is important we should display a notification to the user in all cases.

jaredlockhart commented 5 years ago

Here we should check if the id exists and if it doesn't we shoudl raise a bugzilla error:

https://github.com/mozilla/experimenter/blob/master/app/experimenter/experiments/bugzilla.py#L82

and that way we will catch and create the notification automatically here:

https://github.com/mozilla/experimenter/blob/master/app/experimenter/experiments/tasks.py#L74-L82

and to test this you can mimic the test that exists here:

https://github.com/mozilla/experimenter/blob/master/app/experimenter/experiments/tests/test_bugzilla.py#L48-L80

Softvision-RemusDranca commented 5 years ago

I have verified this issue and I was not able to reproduce it on Experimenter stage "https://stage.experimenter.nonprod.dataops.mozgcp.net" website. Tested on Windows 10x64, Mac 10.14 and Arch Linux 4.16.6 x64.