mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
114 stars 176 forks source link

The padding around the "Send intent-to-ship email" button is not the same #1209

Closed Softvision-RemusDranca closed 5 years ago

Softvision-RemusDranca commented 5 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to "https://stage.experimenter.nonprod.dataops.mozgcp.net/".
  2. Open the experiment from prerequisites.
  3. Observe the "Send intent-to-ship email" button from the "Required Sign-Off Checklist" section.

[Expected result]:

[Actual result]:

[Notes]:

jaredlockhart commented 5 years ago

Ah yep that's a little wonky, we should fix that. I'm also not a huge fan of the button being in the middle of the checklist items (even though I suggested it). Maybe we can move it to somewhere that looks a little less jarring than where it is now?

uhlissuh commented 5 years ago

So glad to see this issue come up, as that button has been bugging me for days now.. 😄 ON IT.

Softvision-RemusDranca commented 5 years ago

I have verified this issue and is no longer reproducible on Experimenter stage "https://stage.experimenter.nonprod.dataops.mozgcp.net/" website after the v2.28.1 stage deployment. Tested on Windows 10x64, Mac 10.14 and Arch Linux 4.16.6 x64.