mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
114 stars 176 forks source link

The Sign-offs order from the "Optional Sign-Off Checklist" changes after each page refresh #1244

Closed Softvision-RemusDranca closed 5 years ago

Softvision-RemusDranca commented 5 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to "https://stage.experimenter.nonprod.dataops.mozgcp.net/".
  2. Open the experiment from prerequisites.
  3. Refresh the page and observe the Sign-offs order from the "Optional Sign-Off Checklist" section.

[Expected result]:

[Actual result]:

[Notes]:

jaredlockhart commented 5 years ago

@tiftran I think if you just wrap the sets in sorted(set(....)) that should be an easy fix.

tiftran commented 5 years ago

@jaredkerim will do, was along the lines of what I was thinking of as well

Softvision-RemusDranca commented 5 years ago

I have verified this issue and is no longer reproducible on Experimenter stage "https://stage.experimenter.nonprod.dataops.mozgcp.net/" website after the v2.28.1 stage deployment. Tested on Windows 10x64, Mac 10.14 and Arch Linux 4.16.6 x64.