Cloning an experiment wrongly validates the previous name of the cloned experiment - Githubissues

mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.

https://experimenter.services.mozilla.com

Mozilla Public License 2.0

114 stars 176 forks source link

Cloning an experiment wrongly validates the previous name of the cloned experiment #1410

Closed Softvision-RemusDranca closed 5 years ago

Softvision-RemusDranca commented 5 years ago

[Affected versions]:

Firefox Release 67.0.4 and above
Chrome 75 and above.

[Affected Platforms]:

All Windows
All Mac
All Linux

[Prerequisites]:

You are logged in your LDAP account on the "https://stage.experimenter.nonprod.dataops.mozgcp.net/" website.
Have an experiment created on Experimenter stage.

[Steps to reproduce]:

Open the browser with the profile from prerequisites and navigate to "https://experimenter.stage.mozaws.net/".
Open the experiment from prerequisites.
Click the "Edit" button from the "Overview" section.
Change the name of the experiment from the "Name" section.
Click the "Save Draft" button.
Click the "Clone this Experiment" button and delete the "V2" string from the prompt displayed.
Click the "Clone" button and observe the behavior.

[Expected result]:

The "This experiment name already exists." error message is displayed.

[Actual result]:

No error message is displayed and the "Clone" button, remains in a "Cloning" state.

[Notes]:

The "Clone" button remains in a "Cloning" state until the page is refreshed.
If the previous name of the cloned experiment is inserted in the "Name of New Experiment:" input field and cloned, results in getting the "This experiment name already exists." error message.
Attached is a screen recording of the issue:

Softvision-RemusDranca commented 5 years ago

I have verified this issue and is no longer reproducible on Experimenter stage website after the v2.30.2 stage deployment. Tested on Windows 10 x64, Mac 10.14 and Arch Linux 4.16.6 x64.