mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
114 stars 176 forks source link

The "Recipe ID" can wrongly be sent to Normandy with the "0" value #1432

Closed Softvision-RemusDranca closed 5 years ago

Softvision-RemusDranca commented 5 years ago

[Notes]:

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to "https://experimenter.stage.mozaws.net/".
  2. Open the experiment from prerequisites.
  3. Click the "Send to Normandy" button.
  4. Insert the value "0" in the "Recipe ID" input field from the modal displayed.
  5. Click the "Send to Normandy" button and observe the behavior.

[Expected result]:

[Actual result]:

[Additional Notes]:

shell1 commented 5 years ago

This is a valid limit that we should check - but i'm OK with it - since only 3 people set those values.