Inconsistent select field UI in rapid experiment form

[pdehaan]

The first two select fields (Features and Audience) use a custom <select> field, whereas the last two select fields (Trigger and Firefox Version) use the native <select> UI. Inconsistent, but probably not a deal breaker (since this is an internal only tool).

Should we also convert the <select /> fields below on L138 and L154?

Originally posted by @pdehaan in https://github.com/mozilla/experimenter/pull/2888

[jaredlockhart]

Some of them are single choice and some are multi choice and I think only the multiple choice need to use the new one?

[jaredlockhart]

Trigger is going away altogether, so I think only Features needs to use XSelect, and Audience and Firefox Version can use a regular select (single choice)

[pdehaan]

We're losing Trigger for MVP? Or is that post MVP? Do we need to update the Figma spec? /cc @AnaMedinac

[jaredlockhart]

Yeah trigger is gone for MVP. Yeah we can use this component for all selects, @tiftran informs me that you can use it for single and multi select cases so it makes more sense to maintain a single select component with consistent labeling/error handling/etc.

[jaredlockhart]

Also I don't like XSelect as the name, especially if we're using it for single and multi case.

[AnaMedinac]

Btw, I've updated the Figma to reflect the removal of trigger for the MVP.

[pdehaan]

This is probably invalid now that we've lost the Trigger dropdown, and it looks like a recent PR converted that last "Firefox Version" dropdown to use the XSelect for consistency greatness.

[tiftran]

Closing as #2993 has addressed this