mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
114 stars 179 forks source link

400 Bad Request console error when trying to Request Approval for a Rapid experiment #3056

Closed pdehaan closed 4 years ago

pdehaan commented 4 years ago

STR

  1. https://stage.experimenter.nonprod.dataops.mozgcp.net/experiments/rapid/beep-de-boop/ (or create a new experiment)
  2. Click the [Request Approval] button.
  3. Open your devtools console.

Actual results

[XHR] POST https://stage.experimenter.nonprod.dataops.mozgcp.net/api/v3/experiments/beep-de-boop/request_review/    [HTTP/2 400 Bad Request 88ms]
Mozilla_Experimenter_and_New_Issue_·_mozilla_experimenter
jaredlockhart commented 4 years ago

This might actually be the correct behaviour, can you do it again and look at the response payload of the 400 request?

pdehaan commented 4 years ago

Oh interesting:

status: [ "You can not change an experiment's status from Review to Review" ]
Mozilla_Experimenter

So I think I was confused because the label said "Draft" so I spammed the button a couple times. And now I'm in a Review state, but i can still press the "Request Approval" button and get that error. I'll have to poke at this tomorrow and see if I can break this apart into separate bugs since there might be a couple different conflicting issues here. 🐟

jaredlockhart commented 4 years ago

Closing as duplicate of https://github.com/mozilla/experimenter/issues/3004