mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
120 stars 186 forks source link

Clicking "Next" in nimbus wizard doesn't save changes #4022

Closed pdehaan closed 3 years ago

pdehaan commented 3 years ago
  1. Go to https://stage.experimenter.nonprod.dataops.mozgcp.net/experiments/nimbus/new and create a new experiment.
  2. On the /${slug}/edit/overview/ page, change the Public name and possibly fill in the hypothesis with a short novella.
  3. Click the "Next" button.

Note that the changes you just made on the overview page were not saved when clicking "Next". In the case of an experiment name, this is mildly annoying. In the case of me filling in a lengthy hypothesis only to have my changes lost, it'd be pretty frustrating data loss.

Making a user click Save then Next each time feels counterintuitive.

┆Issue is synchronized with this Jira Task ┆Issue Number: EXP-613

data-sync-user commented 3 years ago

➤ Les Orchard commented:

If we want next to work this way, it seems like a relatively simple change - next should do what save does and navigate to next step.

data-sync-user commented 3 years ago

➤ Lauren Zugai commented:

Hmm, I know I asked if we wanted "Next" to "Save and Next" and remember being told no. 😅 I think the intended behavior is that "Next" should be disabled if there's any unsaved changes.

jodyheavener commented 3 years ago

I'm not having much luck with #3885 (see my thread) and so having this will probably help prevent accidental data loss (alternatively, disabling Next until you have Saved, but it sounds like there was some pushback there)

data-sync-user commented 3 years ago

➤ Chelsea Lewis commented:

[~amedinac@mozilla.com] [~khudson@mozilla.com] Could either of you chime in here on the questions above?

k88hudson commented 3 years ago

I'd be highly in favour of Save and Continue v.s. disabling since:

k88hudson commented 3 years ago

I just witnessed Alex hitting save like... 3 times to be sure :P

jodyheavener commented 3 years ago

🔨 The consensus is that "Next" will be re-labelled as "Save and Continue" (it must now save and advance to the next page) and "Save" will remain as well (no change).

pdehaan commented 3 years ago

Sounds like the previous/current Experimenter UI/flows (which is good);

Mozilla_Experimenter