search

mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
114 stars 179 forks source link

You can force a NImbus experiment Review state by hacking URL #4100

Closed pdehaan closed 3 years ago

pdehaan commented 3 years ago

https://stage.experimenter.nonprod.dataops.mozgcp.net/experiments/nimbus/sdfadfasdf/request-review

You can see from the sidebar that I'm missing required info for "Audience", as well as a page of errors for experiment owner not being set, missing probes, duration, etc... But I was still able to check a couple checkboxes and set my experiment into the Review state, which seems wrong.

Mozilla_Experimenter

I know hacking URLs probably isn't a valid use case, but there might be a second issue here it shouldnt have let me request review of an experiment that is missing so much required data still.

┆Issue is synchronized with this Jira Task ┆Issue Number: EXP-655

jodyheavener commented 3 years ago

I think #3757 or #3758 should address this.

LZoog commented 3 years ago

@pdehaan closing this, it should no longer be an issue, please reopen if not 🙂