mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
120 stars 186 forks source link

`application` field for Fenix Nightly just shows "fenix" instead of "org.mozilla.fenix" #4235

Closed travis79 closed 3 years ago

travis79 commented 3 years ago

Since the SDK matches the application field against the application_id that is passed in during init, it is expecting the same bundle identifier that is used by the Play Store. This is the only way that channels are currently encoded in mobile that we can target them.

┆Issue is synchronized with this Jira Task ┆Issue Number: EXP-745

jaredlockhart commented 3 years ago

Ah okay this is conflating application and channel. What you're looking for here is channel:

https://github.com/mozilla/experimenter/blob/main/app/experimenter/experiments/constants/nimbus.py#L105-L107

which is exposed in the DTO as channel:

https://github.com/mozilla/nimbus-shared/blob/main/types/experiments.ts#L25

Example in the fenix experiment targeting Fenix Nightly on stage:

https://stage.experimenter.nonprod.dataops.mozgcp.net/api/v6/experiments/fenix-nimbus-validation-2/

Screen Shot 2020-12-11 at 2 21 25 PM
k88hudson commented 3 years ago

@jaredlockhart Let's go with application in the DTO being org.mozilla.fenix – it makes more sense given the way applications are set up from a targeting perspective (although not in the UI)

data-sync-user commented 3 years ago

➤ Tim Smith commented:

Closing in favor of EXP-825.