search

mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.
https://experimenter.services.mozilla.com
Mozilla Public License 2.0
120 stars 186 forks source link

Confusing "Go to Review" button label when looking at an experiment in the Review state #4706

Closed pdehaan closed 3 years ago

pdehaan commented 3 years ago

Re: https://stage.experimenter.nonprod.dataops.mozgcp.net/nimbus/do-not-delete-about-welcome-reference-test

The wording might be a bit weird here where we're in the Review state, and the button says "Go to Review".

do_not_delete_about_welcome_reference_test___Experimenter

For comparison sake, here's a few screenshots for the PREVIEW, LIVE, and COMPLETE experiment states. Once an experiment is Live, the button changes to "Go to Design" with a different icon.

Even the "Go to Review" label during the Preview state might be a bit misleading, since it doesn't actually move the experiment from Preview => Review.

STATE IMAGE
PREVIEW Testing_a_preview_for_previewing_sake___Experimenter
REVIEW pdehaan_2020-12-08_004a___Experimenter
LIVE About_welcome_turn_off_experiment___Experimenter
COMPLETE pdehaan_Default_Firefoxen_Prompt_Retention_Experiment___Experimenter

┆Issue is synchronized with this Jira Task ┆Issue Number: EXP-1015

LZoog commented 3 years ago

We should be able to close this when #4682 is merged 😎

jodyheavener commented 3 years ago

Closing as the issue is resolved