Unpublished changes are lost if an end action is requested and rejected - Githubissues

mozilla / experimenter

A web application for managing user experiments for Mozilla Firefox.

https://experimenter.services.mozilla.com

Mozilla Public License 2.0

118 stars 185 forks source link

Unpublished changes are lost if an end action is requested and rejected #8561

Closed data-sync-user closed 1 year ago

data-sync-user commented 1 year ago

[Prerequisites]:

Have a rollout in the LIVE state.

[Steps to reproduce]:

Navigate to the experiment from prerequisites.
Modify the Audience to a higher or lower value and save the page.
Have someone request an end rollout.
Cancel the review request and observe the page.

[Expected result]:

The Unpublished changes pill is displayed and the update rollout flow can be continued.

[Actual result]:

The Unpublished changes pill is no longer displayed.
Changes made prior to the End Rollout request are still displayed on the summary page.
Further changes do not trigger the Update rollout flow.

[Notes]:

Attached a screen recording of the issue.

┆Issue is synchronized with this Jira Bug ┆Attachments: firefox_w3baYFBSlv.mp4

data-sync-user commented 1 year ago

➤ Ciprian Muresan commented:

I have verified that the issue is no longer reproducible with the current Experimenter Stage version ({"commit": "72783b9313dbf15e091452d629720ca4c9b5d8da", "source": "https://github.com/mozilla/experimenter.git%22, ( https://github.com/mozilla/experimenter.git%22,|smart-link ) "build": "https://circleci.com/gh/mozilla/experimenter/88450"} ( https://circleci.com/gh/mozilla/experimenter/88450%22%7D )).