search

mozilla / extension-activity-monitor

Firefox extension activity monitor
Mozilla Public License 2.0
22 stars 14 forks source link

when filters are set via url, the filters doesn't work #111

Open atiqueahmedziad opened 3 years ago

atiqueahmedziad commented 3 years ago

While working on pr #51, I noticed a weird/ unwanted behaviour while applying filters from urls when there are no logs.

STR:

  1. Install one or two extensions for monitoring activity logs. (Example: https://addons.mozilla.org/en-US/firefox/addon/https-everywhere/)
  2. Open the "Activity Logs Page" from browserAction popup of Extension Activity Monitor.
  3. Generate some logs from installed extensions.
  4. Apply some filters (that will eventually update the URL)
  5. Copy the URL.
  6. Now, close the tab with "Activity Logs Page".
  7. Paste the copied URL in a new tab and go.

Actual Result:

The filters are not applied.

Expected Result:

The filters should have been applied.

Bug Video:

https://youtu.be/PxxsrnCMMz4

atiqueahmedziad commented 3 years ago

I am not liking the way I arranged the logical part in filter-option. I need to rectify it.

Also, can we rename this component to a more generic name? Since filter-option sound very general and the filter-timestamp, filter-keyword can also be referred as filter-option. So, I was thinking of renaming it as filter-checkbox (I couldn't think of any better name :p) since this web component is using checkboxes to apply filter. @rpl and @Rob--W do you have any suggestion on renaming this web component ?

himanshujaidka commented 3 years ago

Should I work on this?