search

mozilla / extension-workshop

Firefox Extension Workshop
https://extensionworkshop.com
100 stars 133 forks source link

Sub-string search not supported #249

Open vcarciu opened 5 years ago

vcarciu commented 5 years ago

Describe the problem and steps to reproduce it:

1.Open https://extensionworkshop-dev.allizom.org/ 2.In searchbox , enter a substring like "communit"

Expected result: We should display results for substrings

Actual results: 0 results , even if we have many results if we search for "community"

caitmuenster commented 5 years ago

@lancecummings, if there's enough time could you look into this?

caitmuenster commented 5 years ago

Actually -- @lancecummings, could you prioritize this?

caitmuenster commented 5 years ago

Closed with #263.

vcarciu commented 5 years ago

Substring search still not working as expected : substring

muffinresearch commented 5 years ago

Ultimately Lunr has limited support for this. As was found with the patch in #263 using wildcards it doesn't really work that well - in fact I don't see any better results using it or not using it (hence this bug being re-opened).

As mentioned in https://github.com/mozilla/extension-workshop/pull/291#issue-308134374 if this is really a problem, then we might want to consider using a more fancy search engine or handing off to a 3rd party one, such as Duck Duck Go because lunr definitely has some limitations and its support for partial matches is quite limited and breaks quite easily.

caitmuenster commented 5 years ago

After having some conversations, we're not going to make this issue a blocker. When we do the soft launch with the community, we're going to collect feedback on how search is performing and then we can reassess this.