Hi! 👋🏼 I'm doing some prototyping with Fathom, and ran into a few dependency-related snags getting fathom train to work. This PR is an attempt to fix all of them up—with this patch stack, fathom train works for me, and prints metrics and results! 🎉
I haven't worked with (or on) Fathom before, but happy to revert or fix up any commits. The individual commit messages have some more details about the versions I chose, but here's a quick summary:
Newer NumPy versions aren't compatible with Fathom's version of tensorboardX, so I pinned NumPy to the newest compatible version.
Selenium 4 has some breaking changes, but 3 isn't compatible with modern Firefoxes, so I bumped the version of Selenium (and geckodriver, on the FathomFox side) and updated the Vectorizer to use it.
Yarn was very confused trying to install FathomFox's dependencies, even after I regenerated FathomFox's copy of yarn.lock. I think it's unhappy that npm install now saves to package.json by default, and generates its own package-lock.json lockfile that interferes with Yarn's. After a bit of debugging, I just replaced Yarn with npm.
I also had to use Python 3.9.13. It looks like 3.11 is too new for the version of PyTorch that Fathom depends on—but I wasn't sure about bumping that dependency just yet.
Hi! 👋🏼 I'm doing some prototyping with Fathom, and ran into a few dependency-related snags getting
fathom train
to work. This PR is an attempt to fix all of them up—with this patch stack,fathom train
works for me, and prints metrics and results! 🎉I haven't worked with (or on) Fathom before, but happy to revert or fix up any commits. The individual commit messages have some more details about the versions I chose, but here's a quick summary:
yarn.lock
. I think it's unhappy thatnpm install
now saves topackage.json
by default, and generates its ownpackage-lock.json
lockfile that interferes with Yarn's. After a bit of debugging, I just replaced Yarn with npm.I also had to use Python 3.9.13. It looks like 3.11 is too new for the version of PyTorch that Fathom depends on—but I wasn't sure about bumping that dependency just yet.
Thanks!
/cc @gleonard-m @DimiDL