search

mozilla / federated-learning-v2-study-addon

Mozilla Public License 2.0
1 stars 2 forks source link

enable frecency pings for all branches so analysis can be performed #16

Closed crankycoder closed 5 years ago

crankycoder commented 5 years ago

We need to upload pings for two distinct reasons :

a) to train a model b) to do post-experiment analysis

We previously disabled uploads for branches that do no require training.

I've enabled uploads across all branches to fix the ability to do post-experiment analysis.

crankycoder commented 5 years ago

r? @motin

motin commented 5 years ago

This change is not strictly necessary since we still send shield-study-addon pings on all interactions. If we do post-experiment analysis using the shield telemetry, we are good. @ilanasegall What do you prefer?

crankycoder commented 5 years ago

We should just leave the client as is if we really don't need the pings for analysis.

On Wed, Mar 27, 2019, 5:46 PM Fredrik Wollsén notifications@github.com wrote:

This change is not strictly necessary since we still send shield-study-addon pings on all interactions https://github.com/mozilla/federated-learning-v2-study-addon/blob/master/docs/TELEMETRY.md#frecency-update-ping-schema. If we do post-experiment analysis using the shield telemetry, we are good. @ilanasegall https://github.com/ilanasegall What do you prefer?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/federated-learning-v2-study-addon/pull/16#issuecomment-477359949, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAS3TpQH6FL0cq9Wuoj_PCH-x_ok9fXks5va-a1gaJpZM4cMjhl .