search

mozilla / firefox-hardware-report

The Firefox Hardware Report was the precursor to the Firefox Public Data Report, to which it now redirects
https://data.firefox.com/dashboard/hardware
27 stars 13 forks source link

Minimize bundle.js payload #113

Closed jasonbarry closed 6 years ago

jasonbarry commented 6 years ago

Fixes #101

Before, bundle.js was about 1.7MB, with this PR it's down to 719KB.

screen shot 2018-07-28 at 3 04 04 pm
openjck commented 6 years ago

This is great, thank you!

Just as a heads up, this codebase is currently being rewritten. It should be replaced in about one month, so although fixes like these are great, I wanted to let you know that major additions/changes probably won't be prioritized right now.

But again, thanks for this fix. I should have been doing this from the beginning.

openjck commented 6 years ago

GitHub is being weird. I merged this but it's saying I didn't. This is on master now.

openjck commented 6 years ago

Hm. GitHub just listed a service issue a moment ago. Everything is on master, but I'll check back on this page in a couple of hours to ensure that this is correctly marked as merged.

openjck commented 6 years ago

Well, the service interruption left this page in a weird state where it doesn't look like a PR any more, but it certainly has been merged.

Thanks again!