mozilla / firefox-translations-training

Training pipelines for Firefox Translations neural machine translation models
https://mozilla.github.io/firefox-translations-training/
Mozilla Public License 2.0
135 stars 28 forks source link

Close resources in alignments for each step #662

Open gregtatum opened 3 weeks ago

gregtatum commented 3 weeks ago

I was debugging alignment failures, and noticed that file handles are only closed at the end of the script running. It would be better to close things after each step is run. I also expanded the docs a bit more. For the review I would recommend hiding whitespace changes, as a lot of indentation changed.

screenshot of the hide whitespace widget

This PR is lower priority, and doesn't fix anything in the current training run. It was just a drive-by as I was looking into the code.