always insert banners before header (1515)

mozilla / fireplace

:fire: Frontend for the Firefox Marketplace

https://marketplace.firefox.com/

Other

116 stars 193 forks source link

always insert banners before header (1515) #1533

Closed spasovski closed 8 years ago

spasovski commented 8 years ago

This won't change anything for the desktop header since it's absolutely positioned. To test this locally try http://pastebin.com/HC0Y5XGA

ngokevin commented 8 years ago

bug #?

spasovski commented 8 years ago

None that I know of, was requested by DDurst.

chuckharmston commented 8 years ago

What about the mac banner?

spasovski commented 8 years ago

Bug 1219083 is open. This isn't meant to address that. @ddurst can weigh in.

ddurst commented 8 years ago

We hadn't filed one yet, this was noticed by QA -- that the banner wasn't shown because it was behind the nav. But, yes, it's similar to but different from 1219083.

chuckharmston commented 8 years ago

Let's get a better commit message then, it sort of implies that you want to do up all the banners in that way.

chuckharmston commented 8 years ago

r+wc

chuckharmston commented 8 years ago

Merging to unblock late customization.