add spoke-header page type (bug 1218945)(1515)

mozilla / fireplace

:fire: Frontend for the Firefox Marketplace

https://marketplace.firefox.com/

Other

116 stars 193 forks source link

add spoke-header page type (bug 1218945)(1515) #1534

Closed spasovski closed 8 years ago

spasovski commented 8 years ago

chuckharmston commented 8 years ago

I don't think the search icon should be appearing on these pages.

chuckharmston commented 8 years ago

r+wc

ngokevin commented 8 years ago

what's the plan with spoke/header? it's a bit inconsistent. it's not on a lot of pages. website/apps detail pages show "X Detail" but addons show "Addon Name"

spasovski commented 8 years ago

It felt out of scope for the core bug but more header titles will become spoke/header as part of the UI debt work coming after 2.5. I'd prefer to keep this PR small so that it has less chances of regressions.