search

mozilla / fireplace

:fire: Frontend for the Firefox Marketplace
https://marketplace.firefox.com/
Other
116 stars 193 forks source link

Use Unicode stars rather than graphical stars for ratings (bug #1036177) #1539

Closed ericapisani closed 8 years ago

ericapisani commented 8 years ago

I couldn’t find stars.svg being used anywhere else so I removed the file.

This has the original fix from PR #1482, and fixes the issue with star selection in the write-a-review modal that was found in #1483.

However, I’m unable to test the issue that was mentioned in #1483 regarding the star sizes being too small on FF on Windows, so this PR is missing that fix.

Before screenshot:

old stars

After screenshots:

new stars screen shot 2015-11-01 at 8 57 43 pm
spasovski commented 8 years ago

On Windows (10 in my case but it happens in 8 also) we see this:

ngokevin commented 8 years ago

Going to pause this since it might cause regressions. Thanks though!