search

mozilla / fireplace

:fire: Frontend for the Firefox Marketplace
https://marketplace.firefox.com/
Other
116 stars 193 forks source link

Bug 1189337 - Remove footer + Sign Out button on settings page #1558

Closed shahbaz17 closed 8 years ago

shahbaz17 commented 8 years ago

Bug fixed. Review this change

spasovski commented 8 years ago

The bug doesn't mention why we're doing this. This PR just removes the two signout/signin links.

shahbaz17 commented 8 years ago

Hi spasovski i am working on this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1189337

shahbaz17 commented 8 years ago

Can you help me ? Why i'm getting these errors

spasovski commented 8 years ago

@shahbaz17 the errors can be ignored for now since they are related to a large refactor last week. That bug has no details apart from its title so I am confused by what the intention of it is.

ngokevin commented 8 years ago

problem we didn't merge this last time because it didn't address tests. tests are all failing now so we should get that fixed first

shahbaz17 commented 8 years ago

So what can i do now? any suggestion?

shahbaz17 commented 8 years ago

hi ngokevin i have updated the code. Can u look into this

shahbaz17 commented 8 years ago

@ngokevin Thanks for the detailed description about this bug. Looking forward to fix more bug