mozilla / fireplace

:fire: Frontend for the Firefox Marketplace
https://marketplace.firefox.com/
Other
116 stars 193 forks source link

Fix hub/spoke header title on author's app list (bug 1227202) #1580

Closed atiqueahmedziad closed 8 years ago

atiqueahmedziad commented 8 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1227202

Before

screen shot 2015-11-28 at 06 01 26

After

screen shot 2015-11-28 at 06 00 30

Before

screen shot 2015-11-28 at 06 01 34

After

screen shot 2015-11-28 at 06 03 16

atiqueahmedziad commented 8 years ago

r?

spasovski commented 8 years ago

While I agree this is a general page quality issue it's good practice to wait until a bug you file is accepted before developing the fix. There may be cases where the behaviour seen is intentional even if it doesn't seem to follow a pattern.

The fix itself looks good so let's wait and see if the bug passes through triage.

atiqueahmedziad commented 8 years ago

oh! I thought it was triaged by seeing ddurst's comment in bug & he set it blocks the UI/UX improvement bug-1189298. So, I thought it might needs a fix urgently. :)

Yeah, surely can wait till triage :) Thanks for the reply!

ddurst commented 8 years ago

We P3'd this on the 24th, so I'll certainly take it if it gets approved.

ngokevin commented 8 years ago

r+wc

ngokevin commented 8 years ago

nice

atiqueahmedziad commented 8 years ago

Thanks for guiding :smiley: