search

mozilla / fireplace

:fire: Frontend for the Firefox Marketplace
https://marketplace.firefox.com/
Other
116 stars 193 forks source link

Fix hub/spoke header for Homepage & My Apps #1590

Closed atiqueahmedziad closed 8 years ago

atiqueahmedziad commented 8 years ago

Homepage

Before

screen shot 2015-12-05 at 06 00 44

After

screen shot 2015-12-05 at 06 00 48

My Apps

Before

screen shot 2015-12-05 at 06 01 06

After

screen shot 2015-12-05 at 06 01 13

atiqueahmedziad commented 8 years ago

r? @ngokevin

ngokevin commented 8 years ago

how does that look in other languages where the string can get long?

atiqueahmedziad commented 8 years ago

I tried a couple of language with Marketplace header- "Firefox Marketplace". But it seems that the string in other languages also not long enough to overflow I tried with Arabic, Bengali, Urdu, Chinese, French. screenshots taken in 320X480 . screen shot 2015-12-06 at 00 15 46 screen shot 2015-12-06 at 00 15 03 screen shot 2015-12-06 at 00 15 30 screen shot 2015-12-06 at 00 17 48

atiqueahmedziad commented 8 years ago

We can increase the title width upto 225px; if so, we can input upto 24 characters. screen shot 2015-12-06 at 00 57 59

ddurst commented 8 years ago

@atiqueahmedziad -- I would say change it to "FirefoxOS Marketplace" and leave it at 215px (assuming it fits).

atiqueahmedziad commented 8 years ago

closing it for #1614