search

mozilla / fireplace

:fire: Frontend for the Firefox Marketplace
https://marketplace.firefox.com/
Other
116 stars 193 forks source link

re-add route_api_args for region, carrier (bug 1263613) #1611

Closed spasovski closed 8 years ago

spasovski commented 8 years ago

Good catch @ddurst. Sorry about the lateness.

This worked well locally and the region got added to each XHR but I encourage further testing.

ddurst commented 8 years ago

I would say we should add back the changes to tests/unit/rewriters.js, but it looks like none of those tests really required those anyway...

diox commented 8 years ago

https://github.com/mozilla/fireplace/commit/08c19f7c8179d67776b93851403f82396046badf also removed some feature profile code that should probably also be kept if we want feature requirements to work.

ddurst commented 8 years ago

@diox Which parts? If we can add them back in today, I can get them pushed today.

diox commented 8 years ago

Everything related to feature profile in that commit :) It's a bit intertwined.

ddurst commented 8 years ago

oy

spasovski commented 8 years ago

If we want to keep feature profiles it's better to revert the original and simply not inject the platform selector template. We can ignore this PR.