search

mozilla / fix-stacks

This program post-processes the stack frames produced by `MozFormatCodeAddress()`.
Apache License 2.0
21 stars 8 forks source link

Remove junk from Breakpad filenames. #24

Closed nnethercote closed 4 years ago

nnethercote commented 4 years ago

This changes annoying filenames like this:

hg:hg.mozilla.org/integration/autoland:caps/BasePrincipal.cpp:04c31e994f29e72dd81a7340100d12f67e48a5b4

which are an artifact of how Firefox constructs its Breakpad files, to this:

caps/BasePrincipal.cpp

This will fix https://bugzilla.mozilla.org/show_bug.cgi?id=1632928.

r? @gabrielesvelto

nnethercote commented 4 years ago

Here is the code responsible for this in the old breakpad stack-fixing script. It only requires that there are four elements after splitting on :, and doesn't check the contents of the four elements at all.

gabrielesvelto commented 4 years ago

Flag me as a reviewer so I can approve it. I thought this applied only to the source files that were generated but I was wrong.

nnethercote commented 4 years ago

Flag me as a reviewer so I can approve it.

I'm confused. I've never bothered properly flagging you as a reviewer on my previous PRs to this repo. Is this one different somehow? I tried to add you as a reviewer via the "Reviewers" UI element at the top right but it's not working for me.

gabrielesvelto commented 4 years ago

Somehow the usual review interface doesn't show up on this PR. Maybe there's something wrong with my account then? I'll try logging out, clearing my cookies and I'll try again.

gabrielesvelto commented 4 years ago

There must have been a problem with my browser or account, after logging back in the review UI was back, oh well.