mozilla / fix-stacks

This program post-processes the stack frames produced by `MozFormatCodeAddress()`.
Apache License 2.0
21 stars 8 forks source link

Update to latest upstream symbolic and implement brekpad-to-native fallback #41

Closed gabrielesvelto closed 3 years ago

gabrielesvelto commented 3 years ago

A couple of changes in this PR:

The macOS tests are failing because of a change that was introduced in upstream symbolic: this change modified the code used for parsing DWARF objects to ignore line entries starting at address 0. The reasoning behind the change is that those entries would be illegal per the DWARF spec and thus the debuginfo must be considered buggy. However, as it happens, our small macOS-specific test has just that kind of entries in the debuginfo. I tried recompiling it with more recent tools from Apple but to no avail.

gabrielesvelto commented 3 years ago

Thanks Kris, I'll open a follow up bug to pull the new version into mozilla-central after merging