search

mozilla / foundation-security-advisories

Canonical source for Mozilla Foundation Security Advisories. http://www.mozilla.org/security/announce/
Mozilla Public License 2.0
20 stars 32 forks source link

add web HoF for Q1 2022 #96

Closed fkiriakos07 closed 2 years ago

tomrittervg commented 2 years ago

Awesome, looks great. Only saw a couple of issues:

When you have a name for a HOF entry but no bounty attachment you'll need to 

./update_hof.py -a ... --hmac email@email.com

Then take that hash and put it manually in the correct place for the credit entries so we can handle their credit correctly in the future. Those fields get auto-created from Bounty attachments, but for HOF only we need to make them manually.

It looks like Khalid was actually in Q2, but we can include him as long as we de-dupe him next month.

I've used your patch to correct where the one I generated was wrong (and fixed those issues above.) I'm running the client one now and will put it up for review by you and Dan tomorrow I expect.

fkiriakos07 commented 2 years ago

Yes I had to do some manual changes to account for the missing attachments.

regarding Khalid's entry, I added the date from when the issue was resolved, would that work? would he be added to that particular quarter?

tomrittervg commented 2 years ago

Actually, he will become the sole entry in a new Q2 quarter, so we probably don't want to do that...

tomrittervg commented 2 years ago

I put up #97