The test_sns_topics_without_subscriptions.py fails on orphaned SNS subscriptions.

mozilla / frost

Unit testing framework for test driven security of AWS, GCP, Heroku and more.

https://mozilla.github.io/frost/

Mozilla Public License 2.0

104 stars 24 forks source link

The test_sns_topics_without_subscriptions.py fails on orphaned SNS subscriptions. #398

Closed Micheletto closed 3 years ago

Micheletto commented 3 years ago

Attempting to get subscription attributes on an orphaned SNS subscription will fail. A subscription can exist without a parent topic and still be in a verified state. SNS subscriptions without parent topics are worth identifying, because they are unusable, but this test will not indicate the correct reason for the failure.

Micheletto commented 3 years ago

As discussed previously: A separate test will be written for finding SNS subscriptions without parent topics, and the test_sns_pending_verified.py test will be modified to filter out tests that fail to retrieve attributes for this reason.

Micheletto commented 3 years ago

I think we can close this issue now. @ajvb ?

ajvb commented 3 years ago

Fixed by #428