Make sure all test id's are reproducible

[ajvb]

Currently, there are a number of tests where part of the test id / resource id is random. This is usually due to the @pytest.mark.parametrize call having two resources but the id function only support one of them, i.e. https://github.com/mozilla/frost/blob/master/aws/iam/test_iam_user_without_mfa.py#L8-L12

This leads to parametrize id's looking something like this: test_iam_user_without_mfa[ajvb-iam_user_mfa_devices9]

In this case, the number at the end of iam_user_mfa_devices9 is based on the order in which the test ran, meaning it is likely to change in the next run.

At the moment, this is not breaking anything, but it is a blocker for having state management around alerts / bugs created from results. Converting that test name and resource id into something key-able would require finicky custom logic.

Instead, all parametrize id's should be reproducible, so having it as test_iam_user_without_mfa[ajvb] or test_iam_user_without_mfa[ajvb-<constant-device-id>]

[ajvb]

List of tests that have this issue (for tracking in branch):

• [x] aws/rds/test_rds_db_snapshot_not_publicly_accessible.py
• [x] aws/rds/test_rds_db_instance_not_publicly_accessible_by_vpc_sg.py
• [x] aws/s3/test_s3_bucket_has_life_cycle_policy.py
• [x] aws/s3/test_s3_bucket_logging_enabled.py
• [x] aws/s3/test_s3_bucket_does_not_grant_all_principals_all_actions.py
• [x] aws/s3/test_s3_bucket_no_world_acl.py
• [x] aws/s3/test_s3_bucket_cors_disabled.py
• [x] aws/s3/test_s3_bucket_versioning_enabled.py
• [x] aws/s3/test_s3_bucket_web_hosting_disabled.py
• [x] aws/s3/test_s3_bucket_versioning_mfa_delete_enabled.py
• [x] aws/iam/test_iam_admin_user_without_mfa.py
• [x] aws/iam/test_iam_user_without_mfa.py