mozilla / frost

Unit testing framework for test driven security of AWS, GCP, Heroku and more.
https://mozilla.github.io/frost/
Mozilla Public License 2.0
104 stars 24 forks source link

Lint our dockerfiles #435

Open hwine opened 3 years ago

hwine commented 3 years ago

Consensus was to add hadolint, but we probably have tuning to do. Our current Dockerfile produces these errors:

Dockerfile:13 DL3005 Do not use apt-get upgrade or dist-upgrade
Dockerfile:13 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Dockerfile:13 DL3009 Delete the apt-get lists after installing something

Do we want to follow the guidance, or ignore these?

hwine commented 3 years ago

@ajvb @g-k See above for current Dockerfile linting output in frost. Some of those are our common practices.

hwine commented 3 years ago

related- see also this in progress RFC -- improvements welcome