mozilla / fx-private-relay-add-on

Companion add-on for Firefox Relay. Keep your email safe from hackers and trackers. Make an email alias with one click, and keep your address to yourself.
https://addons.mozilla.org/en-US/firefox/addon/private-relay
Mozilla Public License 2.0
69 stars 15 forks source link

Relay address textboxes draw overtop other content. #10

Open tomprince opened 4 years ago

tomprince commented 4 years ago

On some pages with in-content popups, textboxes that are detected by firefox relay get drawn over-top the in-content popup. I discovered this on the github organization setting page; when deleting an organization, the billing address, gravatar email and public email text boxes all overwrite the "are you sure you want to delete this" popup. This can be worked around by scrolling the page so they don't overlap the textbox.

Steps to reproduce:

  1. Create a new organization (such as test-org-Ahyoo7ba)
  2. Go the the organization settings page (e.g. https://github.com/organizations/test-org-Ahyoo7ba/settings/profile)
  3. Click the "delete organization button"
  4. Observer that the three relay detected text boxes (i.e. the billing address, gravatar email and public email text boxes) all display on top of the confirmation popup, and without the background shading that the rest of the page gets.
martinthomson commented 4 years ago

Scroll and look at the mailing list signup box on https://www.cjr.org/tow_center_reports/the-guide-to-advertising-technology.php for another example.

birdsarah commented 4 years ago

Scroll and look at the mailing list signup box on https://www.cjr.org/tow_center_reports/the-guide-to-advertising-technology.php for another example.

Here's a screenshot of that including 1password successfully placing button. 1password uses shadow-dom

Screenshot from 2020-10-05 14-33-36

birdsarah commented 4 years ago

The above image does not capture the full extent of the problem. I'll post more screenshots tomorrow.

birdsarah commented 4 years ago

On github org page:

Screenshot from 2020-10-06 13-36-56

After getting delete modal: Screenshot from 2020-10-06 13-36-56

This appears to be a z-index issue

birdsarah commented 4 years ago

As you scroll up the newsletter page, the dom adjustment causes the email clobber the page

Screenshot from 2020-10-26 12-17-28

markSmurphy commented 3 years ago

I've seen this issue too. when returning to academy.newscientist.com/ the email textbox obscures the Captcha 2021-02-07_14h06_00