search

mozilla / fx-private-relay-add-on

Companion add-on for Firefox Relay. Keep your email safe from hackers and trackers. Make an email alias with one click, and keep your address to yourself.
https://addons.mozilla.org/en-US/firefox/addon/private-relay
Mozilla Public License 2.0
68 stars 14 forks source link

Form tag filter in mutation observer causes some email fields to be missed #4

Open reuben opened 3 years ago

reuben commented 3 years ago

While developing mozilla/fx-private-relay#743 I noticed that the filter applied in the mutation observer is causing some fields to be missed in at least one case: https://github.com/mozilla/fx-private-relay/blob/ec83888b1703ca5e80af38d3ec1b01993819b2fd/extension/js/add_input_icon.js#L319-L329

The URL I was testing on is https://subscribe.washingtonpost.com/checkout/payment/?promo=o17_eu_ba&pricingStrategyId=11&tid=privacy_wall

In my tests, simply removing the if (mutation.target.tagName === "FORM") { filter was enough to fix the problem on that page, but I don't know why the filter was introduced in the first place, so I'm opening this issue :)

reuben commented 3 years ago

@lesleyjanenorton you added the mutation observer, what do you think?