Fix #403 - Added error catching to getCurrentPageHostname() bg message function to ensure settings options in the pop-up work on internal browser pages

mozilla / fx-private-relay-add-on

Companion add-on for Firefox Relay. Keep your email safe from hackers and trackers. Make an email alias with one click, and keep your address to yourself.

https://addons.mozilla.org/en-US/firefox/addon/private-relay

Mozilla Public License 2.0

71 stars 14 forks source link

Fix #403 - Added error catching to getCurrentPageHostname() bg message function to ensure settings options in the pop-up work on internal browser pages #404

Closed maxxcrawford closed 2 years ago

maxxcrawford commented 2 years ago

Fixed #403

While testing the add-on on another PR, I ran across this edge case.

To test:

Open add-on in either desktop browser
While on the entry/add-on login page, click the pop-up panel icon
Go to settings panel
Click first setting "Show Relay icon in email fields on websites"
Expected: The setting should toggle off (or back on if off previously) as expected
Go to a login page and confirm setting works as expected (facebook.com, accounts.spotify.com, etc)