mozilla / fx-private-relay-add-on

Companion add-on for Firefox Relay. Keep your email safe from hackers and trackers. Make an email alias with one click, and keep your address to yourself.
https://addons.mozilla.org/en-US/firefox/addon/private-relay
Mozilla Public License 2.0
70 stars 15 forks source link

Update manifest.json with browser-specific permissions #529

Closed maxxcrawford closed 1 year ago

maxxcrawford commented 1 year ago

Summary

Our Chrome submission of the add-on is being rejected because we have a Firefox-specific permission listed in the manifest file: menus

Previously, this permission was ignored. It is now grounds for rejection: https://developer.chrome.com/docs/webstore/troubleshooting/#does-not-work

Jira: https://mozilla-hub.atlassian.net/browse/MPP-3466

TODO:

Starting now, this project will only update the manifest (for Chrome) during build processes. This means without running the proper script, the add-on will not work for Chrome.

Testing

Confirm defaults work for Firefox

Confirm you can work on Chrome locally

Confirm you can build the add-on locally for a targeted platform/stage environment:

[!NOTE]
You can also test by examining the output manifest.json file and confirming that Firefox builds have the menus permission while the Chrome builds have contextMenus.

For Firefox/Stage

For Chrome/Prod