Firefox for Android Breaking Changes

[maxxcrawford]

Jira Spike: https://mozilla-hub.atlassian.net/browse/MPP-3456

Other issues solved:

• https://mozilla-hub.atlassian.net/browse/MPP-3581

• 528

Changes to investigate:

• [x] Update your manifest.json background key and add "persistent": false. e2d8f83cb85cfb49bc48170c94b20249412eaaba
  • [x] Also add gecko_android key 856564a97fbce5c0b721656ea89c3eb9f94e18b5
• [x] Record global state in the storage API, for example storage.session. e2d8f83cb85cfb49bc48170c94b20249412eaaba
• [x] Ensure listeners are registered synchronously at the top-level. ca777a5407a8696672e36ec91871f59c3611f063 1271d1f1b99d97d4af904d059299bb077ed88e0f
• [x] ~Change timers to alarms.~
• [x] ~Switch from using extension.getBackgroundPage for calling a function from the background page, to extension messaging or runtime.getBackgroundPage.~

Testing

This doesn't add any new features, per se. You'll want to confirm that you can log-in, create and re-use masks.

1. Run the add-on on Firefox for Android
2. Run the add-on on Firefox Desktop
3. Run the add-on on Google Chrome

General steps:

• Run add-on
• Expected: First run page should open
• Log into FxA as normal
• From dashboard (website), be sure to create at least one mask
• Open panel
• Expected: Panel should show existing masks / be logged in
• Navigate to imgur.com/signin
• If on desktop
  • Right-click on input field
  • Expected: Context menu items
• Click on Relay icon in input field
• Expected: In-page menu should open
• Click on previously created mask
• Expected: The mask should be injected into the input field

[maxxcrawford]

@pdehaan Thanks for the previous review. I filed two issues (#537, #538) to capture/TODO them.

[rafeerahman]

Ran the add-on from this branch in android, firefox, and chrome.

(Blocking)

Running into one issue, the in-page menu is stuck on loading (on android, firefox and chrome)

Can confirm that running the add-on panel normally works as intended, as well as generating masks. (Also, is this panel supposed to be shrinked like this? Is this a known bug?)