search

mozilla / fx-private-relay-add-on

Companion add-on for Firefox Relay. Keep your email safe from hackers and trackers. Make an email alias with one click, and keep your address to yourself.
https://addons.mozilla.org/en-US/firefox/addon/private-relay
Mozilla Public License 2.0
70 stars 15 forks source link

MPP-3395: Fix for menu size not reverting to its original state upon searching #532

Closed rafeerahman closed 1 year ago

rafeerahman commented 1 year ago

This PR fixes MPP-3395.

Bug description

  1. When searching in the relay add on menu, the sizing can change causing white space (only happens in the "All email masks" tab). image

  2. When searching in the relay add on menu with a premium account and switching to the"All email masks" tab, then removing your search input, the size will not get reverted back to its original state (this only happens in the "All email masks" tab, and you have to click "All email masks" again for it to revert, as seen at the end of the bug demo).

You would need to use the scrollbar to move down and see the "Generate mask" button. (In https://github.com/mozilla/fx-private-relay-add-on/pull/531, this scrollbar is removed. The scrollbar is not needed with this PR's fix though, so there is no conflict here).

See the video here of the bug here:

https://github.com/mozilla/fx-private-relay-add-on/assets/59676643/8f39e98f-d911-484e-b737-e7debd04408a

Demo of fix

https://github.com/mozilla/fx-private-relay-add-on/assets/59676643/0dd3a379-343a-41d3-93d6-ca32b0dae792

How to test

  1. Access a website that has a login form (e.g Reddit, Facebook, Youtube);

  2. Create several masks, Field Icon should now display 2 tabs;

  3. Search for a specific mask inside the Field Icon;

  4. Cycle between tabs;

  5. Observe behavior when removing the search input. The sizing should stay fixed.

Checklist